Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #453 section title level #459

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

NicoHood
Copy link
Contributor

@NicoHood NicoHood commented Dec 2, 2020

Please note:

  • h1 is still used in admin panel
  • h3 is the new default for frontend forms
  • Use title_level attribute to customize the section title level

If the PR gets merged, I will add documentation for that feature as well.

@rhukster rhukster merged commit 67ac5cb into getgrav:develop Dec 3, 2020
@NicoHood
Copy link
Contributor Author

NicoHood commented Dec 4, 2020

As stated in this comment getgrav/grav-learn#356 (comment) we should possibly rethink the admin access twig check. What else could we use?

cc @mahagr

@mahagr
Copy link
Member

mahagr commented Dec 4, 2020

Can you update it to grav['admin'] is defined?

NicoHood added a commit to NicoHood/grav-plugin-form that referenced this pull request Dec 9, 2020
@NicoHood NicoHood mentioned this pull request Dec 9, 2020
@NicoHood
Copy link
Contributor Author

NicoHood commented Dec 9, 2020

#463

rhukster pushed a commit that referenced this pull request Dec 9, 2020
NicoHood added a commit to NicoHood/grav-learn that referenced this pull request Jan 9, 2021
rhukster pushed a commit to getgrav/grav-learn that referenced this pull request Jan 11, 2021
* Added title_level to section docs

Introduced in getgrav/grav-plugin-form#459

* Add section to frontend form documentation

I've removed the underline option, as it is not working with the default themes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants